Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Appearance Tools #52785

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Docs: Update Appearance Tools #52785

merged 1 commit into from
Jul 20, 2023

Conversation

bph
Copy link
Contributor

@bph bph commented Jul 20, 2023

The Documentation on Theme Support was missing two settings for Appearance Tools (see issue)

What?

Adding support for appearance tools adds to more presets for Global Styles

  • dimensions: minHeight
  • position: sticky

Why?

Schema change in #48057 in WordPress 6.2

How?

added two lines

  • dimensions: minHeight
  • position: sticky

Testing Instructions

Docs only change

@bph bph self-assigned this Jul 20, 2023
@bph bph linked an issue Jul 20, 2023 that may be closed by this pull request
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, thank you 👍

@carolinan carolinan added the [Type] Developer Documentation Documentation for developers label Jul 20, 2023
@bph bph merged commit 757113d into trunk Jul 20, 2023
@bph bph deleted the docs/appearancetools branch July 20, 2023 13:06
@github-actions github-actions bot added this to the Gutenberg 16.4 milestone Jul 20, 2023
@bph
Copy link
Contributor Author

bph commented Jul 20, 2023

Thank you @carolinan :-)

westonruter added a commit that referenced this pull request Jul 20, 2023
…ding-strategy

* origin/trunk: (59 commits)
  Promisify action creator return type for WP data dispatch (#52530)
  [RNMobile] Add WP hook for registering non-core blocks (#52791)
  removes check for active preview device type to enable the fixed toolbar preference (#52770)
  Enforce checks against redeclaration for functions and classes (#52696)
  update appearance tools, (#52785)
  Behaviors: Extend Global Styles API to read/write behaviors config. (#52370)
  HeaderToolbar - Update inserterMethod meta data (#52735)
  add options for debugging php unit tests (#52778)
  Docs: Interactivity API > Getting Started Guide - minor adjustments (#52786)
  Footnotes: Use static closures when not using '' (#52781)
  Improve slug generation & matching in request utils (#52414)
  Open "docs" folder for the Interactivity API package and Getting Started Guide (#52462)
  Global Styles: Don't use named arguments for 'sprintf' (#52782)
  E2E utils - Update locator to hide the keyboard on iOS to pick the first element, on iPad two buttons are available and the second one makes the floating keyboard to show up (#52771)
  Patterns: Reinstate template parts mode spec (#52780)
  chore(release): publish
  Update changelog files
  Patterns: Fix empty general template parts category (#52747)
  Add id to pattern inserted notice to stop multiple notices stacking (#52746)
  Site Editor: Fix site link accessibility issues (#52744)
  ...
@bph
Copy link
Contributor Author

bph commented Jul 31, 2023

Also added those lines to the scheduled revision of this page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Appearance Tools needs update
2 participants