[RNMobile] Add WP hook for registering non-core blocks #52791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea of this hook is to allow non-core blocks to be registered right after the core blocks.
fluiddot
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +846 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
2 tasks
|
Flaky tests detected in 7fb8ba6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5612814611
|
geriux
reviewed
Jul 20, 2023
| @@ -70,6 +70,8 @@ const setupInitHooks = () => { | |||
| ) { | |||
| unregisterBlockType( 'core/block' ); | |||
| } | |||
|
|
|||
| doAction( 'native.post-register-core-blocks', props ); | |||
There was a problem hiding this comment.
I've double-checked that the props passed here are the ones expected as from the older approach in https://github.com/WordPress/gutenberg/blob/trunk/packages/react-native-editor/src/index.js#L57-L66 👍
I was wondering if we should remove the native.render action or keep it if it's needed in the future, what do you think? I'm fine with keeping it by the way.
There was a problem hiding this comment.
I've double-checked that the props passed here are the ones expected as from the older approach in https://github.com/WordPress/gutenberg/blob/trunk/packages/react-native-editor/src/index.js#L57-L66 👍
Thanks for checking it 🙇 ! I saw that we only use the capabilities prop when registering the Jetpack blocks, which is already being passed.
There was a problem hiding this comment.
I was wondering if we should remove the
native.renderaction or keep it if it's needed in the future, what do you think? I'm fine with keeping it by the way.
Good question. AFAIK it's not being used anywhere, so I understand we could remove it. If we need it in the future we can always revert it back.
There was a problem hiding this comment.
Sounds good to me! Are we planning to do that in a follow-up PR? This PR is ready for my approval so let me know!
There was a problem hiding this comment.
Ah, sorry. I'm planning to apply the suggestion in this PR. In fact, I noticed that I missed adding a unit test for the new hook. I'll let you know when I pushed the changes, thanks!
There was a problem hiding this comment.
Cool! I'll keep an eye out for those, thanks!
There was a problem hiding this comment.
geriux
approved these changes
Jul 20, 2023
geriux
approved these changes
Jul 20, 2023
westonruter
added a commit
that referenced
this pull request
Jul 20, 2023
…ding-strategy * origin/trunk: (59 commits) Promisify action creator return type for WP data dispatch (#52530) [RNMobile] Add WP hook for registering non-core blocks (#52791) removes check for active preview device type to enable the fixed toolbar preference (#52770) Enforce checks against redeclaration for functions and classes (#52696) update appearance tools, (#52785) Behaviors: Extend Global Styles API to read/write behaviors config. (#52370) HeaderToolbar - Update inserterMethod meta data (#52735) add options for debugging php unit tests (#52778) Docs: Interactivity API > Getting Started Guide - minor adjustments (#52786) Footnotes: Use static closures when not using '' (#52781) Improve slug generation & matching in request utils (#52414) Open "docs" folder for the Interactivity API package and Getting Started Guide (#52462) Global Styles: Don't use named arguments for 'sprintf' (#52782) E2E utils - Update locator to hide the keyboard on iOS to pick the first element, on iPad two buttons are available and the second one makes the floating keyboard to show up (#52771) Patterns: Reinstate template parts mode spec (#52780) chore(release): publish Update changelog files Patterns: Fix empty general template parts category (#52747) Add id to pattern inserted notice to stop multiple notices stacking (#52746) Site Editor: Fix site link accessibility issues (#52744) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a WordPress hook to allow non-core blocks to be registered right after core blocks.
Why?
This is needed to address a crash in Gutenberg Mobile.
How?
Add a WordPress hook named
native.post-register-core-blocksthat is executed right after the core blocks register.Testing Instructions
Follow testing instructions from Gutenberg Mobile PR.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A