Pattern library: Switch to three column layout on huge screens
#52927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +24 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Switch from two column to three column layout on viewports larger than 1440px.
Why?
On wider screens the two column layout can result in extremely large preview thumbnails which feel outsized in comparison with the rest of the UI:
How?
Use
$break-huge(1440px) to switch to three columns:Note: this is the largest breakpoint we have to work with. I think ideally a four column layout would be used at even larger sizes, but that's one to tackle separately as it will require the addition of a new variable.
Testing Instructions