Add xhuge breakpoint and update pattern grid #52942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
Size Change: +28 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #52927
What?
Adds an
xhugebreakpoint (1920px), and uses it to arrange the pattern grid into 4 columns at that size.Why?
The largest breakpoint is currently 1440px which will arguably not cover the use cases we'll need to handle as we tackle admin areas outside of the full screen editor.
How?
$break-xhugevariablebreak-xhuge()mixin.edit-site-patterns__gridBefore
After
Testing Instructions
Note
This is only starting point to kick-off discussion. Perhaps there's an alternative to 1920px?