test: Enable jest-console for native tests #53125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure accidental errors, warnings, or logs are not outputted during tests.
dcalhoun
added
[Type] Automated Testing
|
Size Change: -401 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
dcalhoun
force-pushed
the
test/enable-jest-console-for-native-tests
branch
from
4bf895d
to
6083ac4
Compare
dcalhoun
force-pushed
the
test/enable-jest-console-for-native-tests
branch
from
6083ac4
to
ca0f32f
Compare
Toggling HTML mode results in expected re-renders. We must wrap the invocation in `act` to communicate that to Jest.
Synchronous queries are generally easier to comprehend.
dcalhoun
commented
Jul 28, 2023
Comment on lines
+77
to
+79
| act( () => { | ||
| toggleMode(); | ||
| } ); |
There was a problem hiding this comment.
Toggling HTML mode results in intentional updates and re-renders. We must wrap this call in act to communicate that intent to Jest.
fluiddot
approved these changes
Jul 31, 2023
This library is now included universally for all tests via test environment configuration and setup files.
The log introduces additional, un-filterable noise that can impair one's ability to use logs for debugging.
fluiddot
approved these changes
Aug 1, 2023
.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enable
@wordpress/jest-consolefor the native editor automated tests.Why?
Ensure accidental errors, warnings, and logs are not outputted during tests.
For example, an
actwarning will now cause a test failure.Additionally, this will further align native editor tests with web editor tests.
How?
Enable the
@wordpress/jest-consolepackage within the native tests Jestconfiguration, much like the web editor tests. Add assertions and to do comments
for all pre-existing logs that need to be addressed.
Testing Instructions
n/a
Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a