Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Avoid navigation container dismissing the keyboard #6018

Merged
merged 3 commits into from
Aug 3, 2023
Merged

[RNMobile] Avoid navigation container dismissing the keyboard #6018

merged 3 commits into from
Aug 3, 2023

Conversation

wpmobilebot
Copy link
Collaborator

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 2, 2023 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

1 similar comment
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot self-assigned this Aug 2, 2023
@fluiddot fluiddot added the [Type] Regression Existing functionality that got broken label Aug 2, 2023
@fluiddot fluiddot requested review from SiobhyB and geriux August 2, 2023 17:12
geriux
geriux approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#53270 (review)

@fluiddot fluiddot enabled auto-merge August 2, 2023 17:17
@fluiddot
Copy link
Contributor

fluiddot commented Aug 2, 2023

The unit tests are failing 😭, although it doesn't seem the change coming from the Gutenberg PR is the culprit. Based on the error, I understand this is a side effect of the updates in the Jest configuration: WordPress/gutenberg#53125

I'll take a look tomorrow.

Merge branch 'trunk' into version-toolkit/gutenberg/rnmobile/fix/avoi…
11d10a2 
…d-hide-keyboard-when-opening-block-settings
@SiobhyB SiobhyB disabled auto-merge August 3, 2023 07:31
@SiobhyB SiobhyB enabled auto-merge August 3, 2023 07:38
@fluiddot
Copy link
Contributor

fluiddot commented Aug 3, 2023

The unit tests are failing 😭, although it doesn't seem the change coming from the Gutenberg PR is the culprit. Based on the error, I understand this is a side effect of the updates in the Jest configuration: WordPress/gutenberg#53125

I'll take a look tomorrow.

This issue has been solved by incorporating the latest changes from trunk, specifically the ones coming from #6012. Thanks @SiobhyB for addressing it 🙇 !

@SiobhyB SiobhyB merged commit c3a768f into trunk Aug 3, 2023
@SiobhyB SiobhyB deleted the version-toolkit/gutenberg/rnmobile/fix/avoid-hide-keyboard-when-opening-block-settings branch August 3, 2023 08:01
@SiobhyB SiobhyB mentioned this pull request Aug 3, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

@SiobhyB SiobhyB Awaiting requested review from SiobhyB

Assignees

@fluiddot fluiddot

Labels
[Type] Regression Existing functionality that got broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wpmobilebot @fluiddot @geriux @SiobhyB