Verse: exit on triple Enter #53332
Merged
Verse: exit on triple Enter #53332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +241 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
mtias
reviewed
Aug 4, 2023
mtias
added
the
[Feature] Writing Flow
|
Actually typing out a short poem to me (despite the typo) validates that you are indeed right, triple-enter feels valid to me:
|
jasmussen
approved these changes
Aug 4, 2023
|
I'll add the same setting to Code and Preformatted, since these blocks are nearly identical (or should be). I'll also add some e2e tests. |
|
@jasmussen Your video makes me think we need a caption option for Verse, maybe also even for Preformatted and Code. |
|
I don't know that we necessarily need that, is it wrapped in a But just to clarify, I added that byline mostly for illustrating why triple click to break out of the verse feels valid, the poem isn't actually complete, and if I had made real content I would have probably added some visual stylings. That isn't to say I would necessarily be opposed to the caption button, rather that I didn't immediately feel urgency for one, the Paragraph felt fine to me 👌 |
|
I don't think we need captions on these :) They are a bit clunky |
|
Not captions in the current form, they are clunky |
|
This seems fine to me. I appreciate the apparent discoverability of this and see that it was well considered via discussion in the linked issue. I'd almost rather we have a uniform way to exit any block, with say alt+enter. But that would lack discoverability unless we were to implement some sort of hint when it seems like someone might be trying to exit a block. |
|
@Mamaduka Does this look ok to you? |
|
@ellatrix, can you rebase on top of the latest trunk? |
ellatrix
force-pushed
the
try/verse-split-triple-enter
branch
from
46444e7
to
b392f48
Compare
|
Done |
ellatrix
force-pushed
the
try/verse-split-triple-enter
branch
from
b392f48
to
b7eaeca
Compare
|
Is there a way to break out of a preformatted block, other than at the end? Consider a block of reformatted text:
And you want to break it up and add comments --
I was resorting to editing the HTML to break up large blocks like this. Is it possible to escape out of a PRE, splitting it up in to two PREs or something? |
|
Perhaps triple-enter in the middle of a verse should split it too? |
That seems to be how you can break up a numbered/ordered list. Or perhaps there is a way to add this to the block system, allowing the "..." menu to have a new option to "Split" -- maybe where "Add Before" and "Add After" are. |
|
@ellatrix what do you think about triple-enter to split a verse in two? |
|
For preformatted, maybe, but I'd avoid for verse where it can be a useful expressive tool. |
|
Is there a way to use the context menu to say "split block" or something? That way ENTER can continue to function as it always has, but someone could break up a paragraph, preformatted, code, etc.? |
|
Good point about the expressiveness; if you want multiple linebreaks in a poem that's laid out in a particular way (e.g. Alice in Wonderland), it won't work that three linebreaks breaks it apart. Perhaps we can make it so if you press the down arrow at the end of the verse, it moves the cursor down into the appender, e.g. creates a new paragraph? |
|
I think it's ok to break down at the end of it, I don't think we should force a split in the middle of it. Also, an explicit "split" action might be good to support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #52773.
Why?
It's hard to exit verse.
How?
When the at the end of a verse block, and the two previous characters are line breaks, break out of the block. In other words, exit on triple Enter.
🍒 on the 🥧: when merging two verses, or paragraph with verse, add two line breaks.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast