Button block: support double enter to skip to default block #56134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
commented
Nov 15, 2023
| @@ -47,6 +53,62 @@ const LINK_SETTINGS = [ | |||
| }, | |||
| ]; | |||
|
|
|||
| function useEnter( props ) { | |||
There was a problem hiding this comment.
I was wondering if we could reuse the same hook/code as the list block. It's probably doable but maybe @ellatrix would know more how to better organize these things. So I'm leaving this out of this PR.
There was a problem hiding this comment.
Is it copied over straight from list? Maybe we could temporality move it to a utils file to avoid the duplication until there's an api for it?
There was a problem hiding this comment.
I copied it and remove some list specific stuff.
There was a problem hiding this comment.
But yes, what @Mamaduka said, we can incorporate it into a setting like __experimentalOnEnter later.
|
Size Change: +244 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Maybe |
|
I'll try to check this soon. Interested about accessibility here. |
ellatrix
approved these changes
Nov 16, 2023
|
Thanks for the reviews and happy to address follow-ups if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When trying to use keyboard only to write a post with some buttons and lists, I always get stuck in the buttons block, I write my button text but then don't know how to break out of it to continue just writing. I always try the same technique we do for lists (double enter) but it use to not work on the button block.
I'm not sure if I'm the only one that asked for this but this PR implements this small writing flow improvement (IMO) and matches the behavior of the list block in two ways:
How?
I basically copy/pasted the hook from the button block and adapted it a little bit.
Testing Instructions
1- Create a buttons block.
2- Hit double enter at the end. (try in the middle two).