fix: Horizontal rule accepts style extensions #53917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without applying the `lineStyle` prop to the relevant element, the received styles were lost. Without de-structuring the `style` prop, spreading the entirety of `props` meant passing a `style` value would overwrite _all_ of the existing styles for the component.
dcalhoun
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix existing style props implementation that allow extending the visual
presentation of
HorizontalRule.Why?
The broken style props inhibited the ability to apply custom styles to the
container and line elements.
How?
Without applying the
lineStyleprop to the relevant element, thereceived styles were lost.
Without de-structuring the
styleprop, spreading the entirety ofpropsmeant passing astylevalue would overwrite all of theexisting styles for the component.
Testing Instructions
Testing Instructions for Keyboard
n/a
Screenshots or screencast