Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Redesign mobile editor Jetpack Paywall block visuals #6107

Merged
merged 11 commits into from
Aug 25, 2023
Merged

feat: Redesign mobile editor Jetpack Paywall block visuals #6107

merged 11 commits into from
Aug 25, 2023

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Aug 24, 2023 •
edited
Loading

Redesign mobile editor Jetpack Paywall block visuals. Provide additional context
via visual separation and label text.

Related PRs

Testing Instructions

  • With the web editor, create a post with a Paywall block: <!-- wp:jetpack/paywall /-->
  • Open the same post with the mobile editor.
  • Verify the visuals appear as expected.
Light Mode Dark Mode
paywall-light-mode-2 paywall-dark-mode-2

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun added [Type] Enhancement Improves a current area of the editor Jetpack Bug or feature related to Jetpack labels Aug 24, 2023
@dcalhoun dcalhoun self-assigned this Aug 24, 2023
@dcalhoun dcalhoun mentioned this pull request Aug 24, 2023
Merged
3 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 24, 2023 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun marked this pull request as ready for review August 24, 2023 17:47
@dcalhoun dcalhoun assigned derekblank and unassigned dcalhoun Aug 24, 2023
@dcalhoun
Copy link
Member Author

👋🏻 @derekblank please review and merge this and the associated PRs if you believe they are ready. The submodule references in this branch will need to be updated to the merge commit of the other branches.

derekblank
derekblank approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@derekblank derekblank merged commit e12fa1e into trunk Aug 25, 2023
@derekblank derekblank deleted the feat/redesign-paywall-block branch August 25, 2023 02:19
@geriux geriux added this to the 1.103.0 (23.2) milestone Aug 31, 2023
@geriux geriux mentioned this pull request Aug 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekblank derekblank derekblank approved these changes

Assignees

@derekblank derekblank

Labels
Jetpack Bug or feature related to Jetpack [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.103.0 (23.2)
Development

Successfully merging this pull request may close these issues.
3 participants
@dcalhoun @derekblank @geriux