Update FormTokenField styling for consistency and visibility #54402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
Size Change: -18 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
jasmussen
reviewed
Sep 13, 2023
jasmussen
approved these changes
Sep 13, 2023
|
A very minor point; the current font size, line-height, padding values equate to a 31px height. Is it worth adding |
Sounds good to me. |
I record bigger videos with screen.studio, and these quick ones with clean shot — both have keyboard shortcut visibility options. :) |
ciampo
reviewed
Sep 13, 2023
richtabor
requested review from
TimothyBJacobs,
spacedmonkey,
ntwb,
nerrad,
ellatrix,
michalczaplinski,
tellthemachines,
ajlende,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
Mamaduka
force-pushed
the
improve/form-token-styles
branch
from
57a4e38
to
24f5d5e
Compare
richtabor
removed request for
spacedmonkey,
juanmaguitar,
ntwb,
ajitbohra,
ryanwelcher,
nerrad,
TimothyBJacobs,
ellatrix,
ndiego,
ajlende,
michalczaplinski,
tellthemachines and
fabiankaegy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updated the styling for FormTokenField to make it more consistent with the recent tweaks in #54318, while making the items a bit more visible with increased spacing. This comment details a number of inconsistencies for other consolidation candidates.
Testing Instructions
Screenshots or screencast
I made a couple related PRs to resolve holistic issues that target this component as well (#54398 and #54400). Combined, the controls will look as such:
CleanShot.2023-09-12.at.16.40.43.mp4
Notably, the top border does not clash with the selected color, and the padding looks ace.