Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FormTokenField styling for consistency and visibility #54402

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Update FormTokenField styling for consistency and visibility #54402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c0c2ceb
Update styling to be more consistent/visible/clean
richtabor Sep 12, 2023
24f5d5e
Update CHANGELOG.md
richtabor Sep 12, 2023
5695dab
Put changelog entry in correct place
richtabor Sep 13, 2023
e178bec
Use $border-width
richtabor Sep 13, 2023
3ef84c3
Use $gray-600 instead of rgba
richtabor Sep 13, 2023
6123ed1
Add min-height
richtabor Sep 13, 2023
d179fb2
Merge branch 'trunk' into improve/form-token-styles
richtabor Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- `Tooltip`: Replace the existing tooltip to simplify the implementation and improve accessibility while maintaining the same behaviors and API ([#48440](https://github.com/WordPress/gutenberg/pull/48440)).
- `Dropdown` and `DropdownMenu`: support controlled mode for the dropdown's open/closed state ([#54257](https://github.com/WordPress/gutenberg/pull/54257)).
- `BorderControl`: Apply proper metrics and simpler text ([#53998](https://github.com/WordPress/gutenberg/pull/53998)).
- `FormTokenField`: Update styling for consistency and increased visibility ([#54402](https://github.com/WordPress/gutenberg/pull/54402)).
- `Tooltip`: Add new `hideOnClick` prop ([#54406](https://github.com/WordPress/gutenberg/pull/54406)).

### Bug Fix
Expand Down
14 changes: 5 additions & 9 deletions packages/components/src/form-token-field/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,21 +157,21 @@
.components-form-token-field__suggestions-list {
flex: 1 0 100%;
min-width: 100%;
max-height: 9em;
max-height: $grid-unit-80 * 2;
overflow-y: auto;
transition: all 0.15s ease-in-out;
@include reduce-motion("transition");
list-style: none;
border-top: $border-width solid $components-color-border;
box-shadow: inset 0 $border-width 0 0 $gray-600; // Matches the border color of the input.
margin: 0;
padding: 0;
}

.components-form-token-field__suggestion {
color: $gray-700;
color: $gray-900;
display: block;
font-size: $default-font-size;
padding: 4px 8px;
padding: $grid-unit-10 $grid-unit-15;
min-height: $button-size-compact;
margin: 0;
cursor: pointer;

Expand All @@ -180,7 +180,3 @@
color: $white;
}
}

.components-form-token-field__suggestion-match {
text-decoration: underline;
}
Loading