Fix extra undo/redo step when removing or replacing all blocks #54457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +20 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Sep 14, 2023
Mamaduka
approved these changes
Sep 14, 2023
|
Flaky tests detected in 8f3645e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6184502167
|
ntsekouras
deleted the
fix/extra-undo-redo-step-when-removing-all-blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
By testing this issue I observed when we remove all blocks from a page there is an extra
undo/redostep created. This is because after removing the last block we want to avoid a focus lossan we always add a default block in that case. The issue is fixed by batching these two dispatched actions.
Testing Instructions
undo/redostep on trunk and not in this PRBefore
Screen.Recording.2023-09-14.at.11.07.43.AM.mov
After
Screen.Recording.2023-09-14.at.11.08.36.AM.mov