-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update InputControl and SelectControl default heights #55490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely needs a changelog entry? But yes, we should not use base10 anywhere.
Flaky tests detected in e3beb0f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6624518867
|
Relevant conversation about introducing these size changes: #55401 |
@ciampo how do you think we should proceed here? I don't think an increase of 2px warrants a temporary prop or other affordance due to the minimal impact. |
I personally agree with you — I just wanted to flag it and add more context for any future readers. I believe this PR is good to go once unit tests are fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
What?
Make the default
height
/min-height
forInputControl
andSelectControl
32px
rather than30px
.Why?
Interactive elements like buttons and inputs are trending towards a 24px, 32px, and 40px sizing scale. The current 30px default applied to InputControl and SelectControl violates this convention resulting in awkward sizing mismatches, for example in the data view pagination UI:
The icon button(s) are 32px tall while the page number input is only 30px. This issue will likely become more apparent as we proceed with the admin redesign project.
Testing Instructions
npm run storybook:dev
InputControl
andSelectControl
(and any components that utilise them e.g.UnitControl
) are 32px tall whensize
isdefault
and__next40pxDefaultSize
isfalse
.