Update InputControl and SelectControl default heights #55490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make the default
height
/min-height
forInputControl
andSelectControl
32px
rather than30px
.Why?
Interactive elements like buttons and inputs are trending towards a 24px, 32px, and 40px sizing scale. The current 30px default applied to InputControl and SelectControl violates this convention resulting in awkward sizing mismatches, for example in the data view pagination UI:
The icon button(s) are 32px tall while the page number input is only 30px. This issue will likely become more apparent as we proceed with the admin redesign project.
Testing Instructions
npm run storybook:dev
InputControl
andSelectControl
(and any components that utilise them e.g.UnitControl
) are 32px tall whensize
isdefault
and__next40pxDefaultSize
isfalse
.