Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InputControl and SelectControl default heights #55490

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Update InputControl and SelectControl default heights #55490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d413f8b
Update InputControl and SelectControl default heights
jameskoster Oct 19, 2023
7e563e2
Update changelog
jameskoster Oct 20, 2023
623f754
Changelog
jameskoster Oct 20, 2023
ad4eb65
rebase
jameskoster Oct 20, 2023
e3beb0f
Merge branch 'trunk' into update/default-control-heights
jameskoster Oct 24, 2023
210ade8
Merge branch 'trunk' into update/default-control-heights
jameskoster Oct 25, 2023
2e7f203
Update snapshots
jameskoster Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Enhancements

- `InputControl`/`SelectControl`: update `height`/`min-height` to `32px` instead of `30px` to align with modern sizing scale ([#55490](https://github.com/WordPress/gutenberg/pull/55490)).

### Bug Fix

- `Autocomplete`: Add `aria-live` announcements for Mac and IOS Voiceover to fix lack of support for `aria-owns` ([#54902](https://github.com/WordPress/gutenberg/pull/54902)).
Expand Down
16 changes: 8 additions & 8 deletions packages/components/src/dimension-control/test/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ exports[`DimensionControl rendering renders with custom sizes 1`] = `
white-space: nowrap;
text-overflow: ellipsis;
font-size: 16px;
height: 30px;
min-height: 30px;
height: 32px;
min-height: 32px;
padding-top: 0;
padding-bottom: 0;
padding-left: 8px;
Expand Down Expand Up @@ -390,8 +390,8 @@ exports[`DimensionControl rendering renders with defaults 1`] = `
white-space: nowrap;
text-overflow: ellipsis;
font-size: 16px;
height: 30px;
min-height: 30px;
height: 32px;
min-height: 32px;
padding-top: 0;
padding-bottom: 0;
padding-left: 8px;
Expand Down Expand Up @@ -671,8 +671,8 @@ exports[`DimensionControl rendering renders with icon and custom icon label 1`]
white-space: nowrap;
text-overflow: ellipsis;
font-size: 16px;
height: 30px;
min-height: 30px;
height: 32px;
min-height: 32px;
padding-top: 0;
padding-bottom: 0;
padding-left: 8px;
Expand Down Expand Up @@ -964,8 +964,8 @@ exports[`DimensionControl rendering renders with icon and default icon label 1`]
white-space: nowrap;
text-overflow: ellipsis;
font-size: 16px;
height: 30px;
min-height: 30px;
height: 32px;
min-height: 32px;
padding-top: 0;
padding-bottom: 0;
padding-left: 8px;
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/input-control/styles/input-control-styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ export const getSizeConfig = ( {

if ( ! __next40pxDefaultSize ) {
sizes.default = {
height: 30,
height: 32,
lineHeight: 1,
minHeight: 30,
minHeight: 32,
paddingLeft: space( 2 ),
paddingRight: space( 2 ),
};
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/select-control/styles/select-control-styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ const sizeStyles = ( {

if ( ! __next40pxDefaultSize ) {
sizes.default = {
height: 30,
minHeight: 30,
height: 32,
minHeight: 32,
paddingTop: 0,
paddingBottom: 0,
};
Expand Down
Loading