DataViews: simplify filters API #55917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Code Quality
|
Size Change: -13 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 8, 2023
| @@ -231,7 +231,7 @@ export default function PagePages() { | |||
| </a> | |||
| ); | |||
| }, | |||
| filters: [ 'enumeration' ], | |||
| filters: [ 'in' ], | |||
There was a problem hiding this comment.
This is the only change that I was not sure about because maybe enumeration is the "type" we should define and the available operators for that particular filter type should be a nested config or something but this is also a good approach for now, so let's just keep it that way.
There was a problem hiding this comment.
I gave this a shot at #55996
youknowriad
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Update filters API to:
fieldinstead ofidas key to identify the filteroperatorinstead oftypeas keyininstead ofenumerationfor the operatorTesting Instructions