DataViews: update field API to generate filters based on type #55996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Feature
|
Size Change: -45 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Nov 17, 2023
oandregal
added
[Type] Experimental
oandregal
force-pushed
the
update/add-field-type-to-filter
branch
from
f5fc648
to
8ed8ff8
Compare
|
I had to rebase from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related #55917 (comment)
What?
This PR updates the field API to generate the filters based on the field
type– and it removes the existingfiltersprop.Why
Follow-up on conversations about filters. This is what I see:
type: enumeration. By default, we may offerINandNOT_INoperators but some fields may want to disable support forNOT_IN. In the current design, disabling one of the operators would mean the UI won't show the "settings" submenu:type: date. By default, we may offerBEFORE,AFTER, andPRESET_RANGE("today", "this week", "last month", etc.) operators. See conversation). Some fields may not support all of that, or may want different preset ranges available ("this hour", "last hour", "today" instead of "last mont", "last year"), depending on the frequency of the data. Not design for this, but the same rationale could apply here.How
So far, providing the field
typeis enough.However, we need to plan to configure the filters in upcoming PRs (adding
NOT_INoperator, addingDATEfilter, etc.). This is how it could work (this is not to implement in this PR, but I wanted to share the direction):Testing Instructions