Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoomed out mode: remove button in toolbar #56769

Conversation

glendaviesnz
Copy link
Contributor

What?

Removes the zoomed out mode toggle button from the site editor header

Why?

Part of the work to look at make the zoomed out mode instead be invoked automatically when the pattern inserter is opened.

How?

Deletes the toggle button code from header bar in site editor.

Testing Instructions

Enable the Zoomed out view experiment
Go to the site editor and make sure zoomed out toggle does not appear in header

Screenshots or screencast

Before:
Screenshot 2023-12-05 at 10 52 07 AM

After:
Screenshot 2023-12-05 at 10 51 13 AM

@glendaviesnz glendaviesnz added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Dec 4, 2023
@glendaviesnz glendaviesnz self-assigned this Dec 4, 2023
@glendaviesnz glendaviesnz changed the base branch from trunk to try/zoomed-out-mode-experiments December 4, 2023 22:53
@talldan talldan added the [Type] Enhancement A suggestion for improvement. label Dec 5, 2023
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But maybe hold off merging until there's another way to invoke zoomed out view (opening patterns in the inserter).

@talldan talldan merged commit ddb378f into WordPress:try/zoomed-out-mode-experiments Dec 6, 2023
52 of 56 checks passed
@draganescu draganescu mentioned this pull request Mar 6, 2024
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants