Editor: Move the BlockCanvas component within the EditorCanvas component #56850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
commented
Dec 7, 2023
youknowriad
force-pushed
the
update/move-block-canvs
branch
from
45256a3 to
a74c546
Compare
|
Size Change: +762 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
youknowriad
commented
Dec 7, 2023
| ? 'cursor: pointer; min-height: 100vh;' | ||
| : '' | ||
| }}}` | ||
| }</style> |
There was a problem hiding this comment.
I moved this style tag to the "styles" object. (we do something similar in the post editor)
ellatrix
approved these changes
Dec 7, 2023
getdave
previously requested changes
Dec 7, 2023
getdave
dismissed
their stale review
Weirdly I can no longer replicate this. Apologies for the confusion.
|
@getdave You're saying it's ok right? |
|
Well there's clearly some e2e test failures. Let's see |
|
Ok I had inverted the condition to iframe the editor :) |
|
Flaky tests detected in 437b307. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7126565788
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
In my quest to unify the post and site editor code bases, one of the steps is to unify the "canvas" of the editor. In this PR, I just move the
BlockCanvasrendering to the unifiedEditorCanvascomponent.In the process, it allowed me to remove the "dropzoneElement" prop but forced me to add some other temporary props (styles, iframeProps) which I hope to remove later with further unification.
Testing Instructions
Nothing really, just ensures the editors continues to render as before.