Navigation editor: Fix content mode #56856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Dec 7, 2023
|
Flaky tests detected in 428cc01. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7127485535
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #56000 we move the "content mode" enabling of the navigation block editor from the site editor to the editor provider but we introduced a subtle race condition, where the "content mode" was not set properly if the "blocks" were not set yet in the "BlockEditorProvider".
This PR fixes that by moving that hook under the "BlockEditorProvider" in the block tree and also updates to be reactive, as soon as the root block clientId changes, it retrievers the "content mode".
Testing instructions