Only enter the zoom-out mode when not in the focus mode #56885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Experimental
kevin940726
commented
Dec 8, 2023
| @@ -47,6 +47,7 @@ function InserterMenu( | |||
| prioritizePatterns, | |||
| __experimentalOnPatternCategorySelection, | |||
| __experimentalShouldZoomPatterns = false, | |||
| onSelectTab, | |||
There was a problem hiding this comment.
We might want to mark this private if we ever want to land this on trunk.
|
|
||
| const previousLocationRef = useRef( location ); | ||
| useEffect( | ||
| function closeInserterOnNavigate() { |
There was a problem hiding this comment.
Ideally, we should find a better way and place to manage this when we have a better routing system.
|
Size Change: +99 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5c7ded2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7135626627
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #56806.
Do not enter the
zoom-outmode when opening the patterns inserter when we're in the focus mode (template-part, patterns, etc).Why?
The zoom-out mode is designed to be used in the templates/pages so that it can zoom out to a wider view, which is not suitable for the focus mode where we want more granular controls.
How?
Move around some APIs and only invoke
setEditorModewhen it's not in the zoom-out mode.Testing Instructions
Screenshots or screencast
Kapture.2023-12-08.at.13.18.40.mp4