Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Guard against a block styles crash due to null block values #56903

Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix: Guard against a block styles crash due to null block values #56903

merged 2 commits into from
Dec 8, 2023

Commits on Dec 8, 2023

  1. fix: Guard against a block styles crash due to null block values 

    In certain scenarios, e.g., when the editor hangs due to poor
performance, the `getBlock` value unexpectedly returns `null`. To guard
against a crash in this scenario, we now conditionally access attributes
on the block.

A ideal resolution would be improving editor performance to avoid the
scenario where a race condition causes a crash, but the fact remains
that `getBlock` _can_ return `null` values and that we should not
presume that it will not.
    @dcalhoun
    dcalhoun committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    a9cc054 View commit details
    Browse the repository at this point in the history

  2. docs: Add change log entry

    @dcalhoun
    dcalhoun committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    d57cf63 View commit details
    Browse the repository at this point in the history