Interactivity Router: Move ARIA live region and loading bar to the Interactivity Router #58377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Enhancement
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/interactivity-api/class-wp-interactivity-api-wp-router-region-test.php ❔ lib/compat/wordpress-6.5/interactivity-api/class-wp-interactivity-api.php ❔ phpunit/blocks/render-query-test.php |
47 tasks
|
Size Change: -146 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
luisherranz
requested changes
Jan 31, 2024
There was a problem hiding this comment.
I haven't tested it yet, but initially it looks great to me!
We need to add options to opt-out of both things:
const { actions } = yield import('@wordpress/interactivity-router');
actions.navigate("/...", {
loadingAnimation: false,
screenReaderAnnouncement: false,
});I also have some additional suggestions/questions.
lib/compat/wordpress-6.5/interactivity-api/class-wp-interactivity-api.php
Show resolved
Hide resolved
8 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
luisherranz
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Epic: #56803
Move the logic that renders and controls the loading top bar and the ARIA live region―both elements that inform about client-side navigations―from the Query block to the Interactivity Router module and the
wp-router-regiondirective processor.Also, the
@wordpress/interactivity-routermodule exposesstate.url, containing the current URL.Why?
We want that logic to be general for any block using client-side navigations, not just for the Query block.
How?
@wordpress/interactivity-routermodule.data_wp_router_region_processor, inside theWP_Interactivity_APIclass.Testing Instructions
Testing Instructions for Keyboard