Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test: Fix "directives inside islands should not be hydrated twice" #58516

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Flaky Test: Fix "directives inside islands should not be hydrated twice" #58516

merged 1 commit into from
Jan 31, 2024

Conversation

DAreRodz
Copy link
Contributor

What?

Fixes #58332.

The fix was originally included in #58377, but as that PR still needs more iteration, I cherry-picked the fix here.

@DAreRodz DAreRodz added [Type] Flaky Test Auto-generated flaky test report issue [Packages] Interactivity /packages/interactivity labels Jan 31, 2024
luisherranz
luisherranz approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luisherranz luisherranz added the [Type] Bug An existing feature does not function as intended label Jan 31, 2024
@luisherranz luisherranz enabled auto-merge (squash) January 31, 2024 18:08
@luisherranz luisherranz merged commit 57607b0 into trunk Jan 31, 2024
57 of 63 checks passed
@luisherranz luisherranz deleted the fix/flaky-test-directives-inside-islands-hydrated-twice branch January 31, 2024 18:30
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 31, 2024
@luisherranz luisherranz mentioned this pull request Jan 31, 2024
Closed
@DAreRodz DAreRodz removed the [Type] Bug An existing feature does not function as intended label Jan 31, 2024
@MaggieCabrera MaggieCabrera added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisherranz luisherranz luisherranz approved these changes

@cbravobernal cbravobernal Awaiting requested review from cbravobernal

@kevin940726 kevin940726 Awaiting requested review from kevin940726

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

Assignees
No one assigned
Labels
[Packages] Interactivity /packages/interactivity [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Milestone
Gutenberg 17.7
Development

Successfully merging this pull request may close these issues.

[Flaky Test] directives inside islands should not be hydrated twice
3 participants
@DAreRodz @luisherranz @MaggieCabrera