Font Library: Do not register the google fonts collection if already registered

[youknowriad]

What?

In order to test this properly, you'll have to run this PR on top of the following Core patch WordPress/wordpress-develop#6056

You shouldn't see any error due to "double registration of google-fonts" collection.

This PR is blocking the introduction of the google fonts collection into Core.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props youknowriad, get_dave, mmaattiiaass.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.5/fonts/fonts.php
❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController.php

[youknowriad]

Looks like there's some php unit test failures 🤔

[youknowriad]

@matiasbenedetto any idea what's happening with the php test failures here?

[getdave]

Rest server has not the collections path initialized.

This error message also needs grammar updating to

Rest server does not have the collections path initialized.

[matiasbenedetto]

Failed asserting that actual size 2 matches expected size 1.

It seems like the /font-collections/ rest API endpoint is repeated.

This is the assertion failing:

$this->assertCount( 1, $routes['/wp/v2/font-collections'], 'Rest server has not the collections path initialized.' );

It seems unrelated to this PR and produced by the double registration of the font collection endpoint (in core and in the plugin).
We would need to add some conditional to these lines in the plugin:

gutenberg/lib/compat/wordpress-6.5/fonts/fonts.php

Lines 102 to 106 in ff37abf

	*/
	function gutenberg_init_font_library() {
	gutenberg_create_initial_post_types();
	gutenberg_create_initial_rest_routes();
	}

[youknowriad]

It seems that the practice for other endpoints has been to double the expect call in the tests. So I did that in the last commit. I think personally that we could consider removing this kind of assertions entirely, but let's leave that separate.

[youknowriad]

Actually, I just went ahead and removed these two assertions from this test.

[matiasbenedetto]

Now the Rest API is merged into core, could we remove the tests for the font library rest API endpoints entirely?

[youknowriad]

@matiasbenedetto I think so yes, since the class being tests is actually the one in Core (due to the class_exists check), but let's do that in its own PR.

[matiasbenedetto]

LGTM