Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Register the Google Font collection #6056

Closed

Conversation

youknowriad
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/59166

This PR register the google fonts collection allowing users to install Google Fonts if they wish to.

Testing instructions

  • Go to the site editor
  • Open the global styles panel
  • Open typography
  • Click on the "Aa" icon to open the font library
  • On the third panel, you should be able to enable google fonts and install them properly.
Screenshot 2024-02-07 at 10 27 14 AM

@youknowriad youknowriad self-assigned this Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props youknowriad, get_dave, mcsf.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: mcsf <mcsf@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Feb 7, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@youknowriad youknowriad force-pushed the add/google-font-collection branch from 431390f to 1fa2ff5 Compare February 7, 2024 10:02
@youknowriad
Copy link
Contributor Author

Looks like this is failing the e2e tests, it seems that the Gutenberg plugin need to "unregister" the font before registering it. We'd have to do a patch release on Gutenberg before shipping this commit to Core.

src/wp-includes/fonts.php Outdated Show resolved Hide resolved
Copy link

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy. LGTM, tests well, but I left a suggestion.

src/wp-includes/fonts.php Outdated Show resolved Hide resolved
@youknowriad
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants