Modal: add box-sizing reset style
#58905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
requested review from
ajitbohra,
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -80 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #58871
Part of #42415
What?
This PR applies
box-sizingreset style to theModalcomponent itself to prevent unintended horizontal scrollbars from appearing in any context.In all editor instances, we have already applied
box-sizingreset style to this component, so nothing should change, but it will fix the appearance of theGuidecomponent on the Storybook.Why?
There are no problems when this component is used in the post editor or site editor, but if you use this component elsewhere and there is content inside an element with padding, an unintended overflow may occur.
How?
Applied a
box-sizingreset style to the component itself and removed the reset mixin when it was no longer needed.Testing Instructions