Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: add box-sizing reset style #58905

Merged
merged 2 commits into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Bug Fix

- `Modal`: Add `box-sizing` reset style ([#58905](https://github.com/WordPress/gutenberg/pull/58905)).

### Experimental

- `CustomSelectControlV2`: Adapt component for legacy usage ([#57902](https://github.com/WordPress/gutenberg/pull/57902)).
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/modal/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

// The modal window element.
.components-modal__frame {
@include reset;
// Use the entire viewport on smaller screens.
margin: $grid-unit-50 0 0 0;
width: 100%;
Expand Down
3 changes: 1 addition & 2 deletions packages/edit-post/src/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ body.js.block-editor-page {
.edit-post-header,
.edit-post-text-editor,
.edit-post-sidebar,
.editor-post-publish-panel,
.components-modal__frame {
.editor-post-publish-panel {
@include reset;
}

Expand Down
7 changes: 1 addition & 6 deletions packages/edit-site/src/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,8 @@ body.js.site-editor-php {
background: $gray-900;
}

.edit-site,
// The modals are shown outside the .edit-site wrapper, they need these styles.
.components-modal__frame {
@include reset;
}

.edit-site {
@include reset;
height: 100vh;

// On mobile the main content area has to scroll, otherwise you can invoke
Expand Down
8 changes: 1 addition & 7 deletions packages/edit-widgets/src/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,8 @@ body.js.widgets-php {
@include wp-admin-reset( ".blocks-widgets-container" );
}

.blocks-widgets-container,
// The modals are shown outside the .blocks-widgets-container wrapper, they need these styles
.components-modal__frame {
@include reset;

}

.blocks-widgets-container {
@include reset;
// On mobile the main content area has to scroll, otherwise you can invoke
// the overscroll bounce on the non-scrolling container, for a bad experience.
@include break-small {
Expand Down
Loading