Allow editing of image block alt and title attributes in content only mode #58998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
artemiomorales and
michalczaplinski
as code owners
49 tasks
|
Size Change: +416 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3d24de9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7897813865
|
|
This tested well for me. The image component is already quite large though so I wonder if it would be better to extract this to a separate |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I thought about it. I wonder if it might be an option to move all the controls into one edit: Looked into it, it ends up being quite a bit change, so might be best for after 6.5 is shipped. |
glendaviesnz
approved these changes
Feb 15, 2024
kevin940726
approved these changes
Feb 16, 2024
Thanks, I'll follow up on this with a PR for the components package. |
|
Long term I'd like to look at re-thinking the idea that you can't select child blocks and see their own inspector when inside a content only block as we run into editing inconsistencies like this. We can also look at surfacing overrideable properties within the parent inspector much like Figma. For now, since this is an accessibility concern and only applies to contentOnly blocks, I think it would be fine to ship the approach implemented here. Keen to here @jameskoster , @richtabor opinions on this though. |
talldan
deleted the
try/image-block-alt-and-title-editing-for-overrides
branch
aristath
added a commit
that referenced
this pull request
Feb 16, 2024
* trunk: (78 commits) Components: Use `Element.scrollIntoView()` instead of `dom-scroll-into-view` (#59085) DataViews: Correctly display featured image that don't have image sizes (#59111) Elements: Fix block instance element styles for links applying to buttons (#59114) Allow editing of image block alt and title attributes in content only mode (#58998) Add toggle for grid types and stabilise Grid block variation. (#59051) Global Styles: fix console error in block preview (#59112) Navigation: Avoid using embedded records from fallback API (#59076) Refactor responsive logic for grid column spans. (#59057) Editor: Unify Mode Switcher component between post and site editor (#59100) Move StopEditingAsBlocksOnOutsideSelect to Root (#58412) Fix logic error in #58951 (#59101) Block-editor: Auto-register block commands (#59079) Fix small typo in rich text reference guide (#59089) Components: Add lint rules for theme color CSS var usage (#59022) Enter editing mode via Enter or Spacebar (#58795) Updating Storybook to v7.6.15 (latest) (#59074) CustomSelectControl (v1 & v2): Fix errors in unit test setup (#59038) Add stylelint rule to prevent theme CSS vars outside of wp-components (#59020) ColorPicker: Style without accessing InputControl internals (#59069) Pattern block: batch replacing actions (#59075) ...
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
… mode (#58998) * Add content only controls for alt and title to image block toolbar * Switch to plain `Dropdown` component to ensure correct semantics inside popover * Iterate on copy and translator comment * Iterate again Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: glendaviesnz <glendaviesnz@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: SaxonF <saxonafletcher@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 97eb1e1 |
getdave
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
… mode (#58998) * Add content only controls for alt and title to image block toolbar * Switch to plain `Dropdown` component to ensure correct semantics inside popover * Iterate on copy and translator comment * Iterate again Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: glendaviesnz <glendaviesnz@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: SaxonF <saxonafletcher@git.wordpress.org>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #53705
One of the challenges of editing a block in
contentOnlymode is that the entire block inspector is unavailable. The mode has an assumption that there are no 'content' controls within the block inspector.For the image block there are some content controls, 'Title' and 'Alternative text'. That they're unavailable has a direct impact on pattern overrides, as it uses contentOnly mode.
How?
For this PR, I've added the controls to the block toolbar, but only when contentOnly mode is active:
When the image block isn't in content only mode they appear back in the inspector as normal.
Testing Instructions