Style Book: should persist when browsing global styles panels #59261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +51 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c1f2ddb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8013519730
|
|
Tested this on WP Playground and it works great! Thanks for jumping on this. The only oddity I noticed is the way the zoomed out view of the template moves "up" into place when you switch back to the style book. Not sure why that's happening or if we can mitigate it. I'd rather have that as a problem though than not be able to switch into the style book with ease: Screen.Recording.2024-02-22.at.11.16.35.AM.mov |
Thanks for testing! This is a feature of the zoom out view I believe, or at least the attached animation, as the frame resizes and repositions itself. |
andrewserong
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Nice fix @ramonjd this is working seamlessly for me!
2024-02-23.11.59.38.mp4
✅ Confirmed on trunk that opening the style book resets the path
✅ With this PR applied, I can toggle the style book within global styles (style variations, block-level styles, etc) and the sub-screen I'm on is persisted 👍
✅ Revisions toggle will still force the redirect to the revisions screen as expected
LGTM! ✨
…bal styles panel. Adds exceptions for the revisions panel. If it's closed, the panel should close by returning to root. E2E tests as well :)
…ook should remain open when closing the revisions panel
ramonjd
force-pushed
the
update/global-styles-style-book-navigation
branch
from
dfaff61 to
c1f2ddb
Compare
ramonjd
added
the
Backport to WP 6.7 Beta/RC
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Ensures that the style book remains open when browsing around the global styles panel. Adds exceptions for the revisions panel. If it's closed, the panel should close by returning to root. E2E tests as well :) * With the style book activated in global styles revisions, the style book should remain open when closing the revisions panel * We don't need to set the current path Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 83ef19f |
getdave
added
Backported to WP Core
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Ensures that the style book remains open when browsing around the global styles panel. Adds exceptions for the revisions panel. If it's closed, the panel should close by returning to root. E2E tests as well :) * With the style book activated in global styles revisions, the style book should remain open when closing the revisions panel * We don't need to set the current path Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #59223
Hi!
This PR ensures that the style book remains open, if activated, when browsing around the global styles panel.
Why?
It could be pretty handy to have the style book remain open when changing global styles, e.g.,
How?
A bit of if else faffery.
If the editor canvas container toggles the "style book", stay on the same global styles panel.
Exceptions:
/Testing Instructions
Test cases:
Screenshots or screencast
Before
2024-02-22.15.20.46.mp4
After
2024-02-22.15.22.39.mp4