Global styles: do not navigate twice to home screen when opening the sidebar #65523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -16 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 34c3550. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10958908801
|
ciampo
added
[Type] Bug
|
@ramonjd @andrewserong @Mamaduka I'm not really sure if this change introduces unintended regressions, but I figured you are the most indicated reviewers as you worked on #59261 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Sep 20, 2024
|
Hmm I'm seeing a max depth exceeded in the 2024-09-23.10.32.09.mp4I'll see if I can get more info... |
I was seeing that, too. I've just rebased against Edit: possibly resolved by #65533 |
ramonjd
reviewed
Sep 23, 2024
| if ( path !== '/' && ! isRevisionsOpen ) { | ||
| return; | ||
| if ( path !== '/' && isRevisionsOpen ) { | ||
| goTo( '/' ); |
There was a problem hiding this comment.
Hmm, in my testing so far, I think we could get right of the entire default block.
Kapture.2024-09-23.at.10.50.28.mp4
There was a problem hiding this comment.
Me likes more red! Pushed an update with the whole default block removed
Good call! Thanks Edit: working normally now. 👍🏻 I'm still convinced that getting right of the entire default block wouldn't hurt. I can't yet see any difference in behaviour. |
ciampo
force-pushed
the
fix/global-styles-duplicate-initial-navigation
branch
from
34c3550
to
0924465
Compare
andrewserong
approved these changes
Sep 24, 2024
|
LGTM! I'll merge |
ciampo
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 2, 2024
…sidebar (#65523) * Global styles: do not navigate twice to home screen on sidebar load * Remove whole default block Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 7d60169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Extracted from #64777
Prevent
Navigatorfrom navigating twice to the home screen when opening the Global Styles sidebar.Why?
The double navigation cause the first screen displayed in the Global Styles sidebar to animate, which is not the expected behavior (the enter animation should be skipped on the first screen)
How?
By inverting the logic of a check inside a
useEffectin the global styles sidebar code.Testing Instructions
Screenshots or screencast
trunk)Kapture.2024-09-20.at.14.24.56.mp4
Kapture.2024-09-20.at.14.26.11.mp4