Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text align block controls #60

Closed
wants to merge 20 commits into from
Closed

Text align block controls #60

wants to merge 20 commits into from

Conversation

BE-Webdesign
Copy link
Contributor

Fixes #54. Adds event handlers following the way image block controls work. This will work for any text type and the css classes, for now, cover p, h1-6, and blockquote.

BE-Webdesign and others added 11 commits February 9, 2017 18:52
Adds text level block controls for alignment.
Revert text alignment to be in sync with main repo.
The usage of apend strings was causing a bug where the same class was added N times as the element
was selected so in order to prevent this we can just make a switch to the functions provided by
classList with the same behavior:

- add
- remove
This change uses a new line instead of the second argument to add a new class, because the multiple
paremeters is not supported on IE 10.
@mcsf
Copy link
Contributor

mcsf commented Feb 13, 2017

screen shot 2017-02-13 at 11 38 56

^ I don't know what happened here 😄 but you probably need to rebase the branch against the latest WordPress:master and ideally group these changes under one commit. Let me know and I can merge this!

mitogh and others added 9 commits February 13, 2017 08:28
Previously add was not reseting to the original state of each block.
…bles headings, and paragraphs to properly change from left aligned, to center, or right aligned. The CSS currently only supports paragraphs, headings 1-6, and blockquote HTML elements.
Use classlist instead of appending and removing class names
…bles headings, and paragraphs to properly change from left aligned, to center, or right aligned. The CSS currently only supports paragraphs, headings 1-6, and blockquote HTML elements.
…bles headings, and paragraphs to properly change from left aligned, to center, or right aligned. The CSS currently only supports paragraphs, headings 1-6, and blockquote HTML elements.
@BE-Webdesign BE-Webdesign deleted the text-align-block-controls branch February 13, 2017 19:43
omarreiss pushed a commit that referenced this pull request Jun 26, 2018
Jest-console: Add new package with console object matchers for Jest
hypest pushed a commit that referenced this pull request Nov 2, 2018
hypest pushed a commit that referenced this pull request Nov 2, 2018
Improve dependency checking for scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants