getEntityRecords: batch actions #60591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
commented
Apr 9, 2024
packages/core-data/src/resolvers.js
Outdated
| ].join(), | ||
| }; | ||
| ( { dispatch, registry } ) => { | ||
| registry.batch( async () => { |
There was a problem hiding this comment.
Question: does the resolver callback need to remain async? Does that mean batch needs to become async?
Question: could we build in batching resolver callbacks?
There was a problem hiding this comment.
Cc @youknowriad and @jsnajdr cause I don't really know what I'm doing here.
There was a problem hiding this comment.
This is not supported. This comment is relevant #60495 (comment)
There was a problem hiding this comment.
I don't think batching async stuff make sense. You want to UI and meta selectors (isResolving) to actually update to show spinners... when requests are ongoing
There was a problem hiding this comment.
Yep, I understand now. I changed the PR to only batch the non async actions now.
|
Size Change: -3 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 9, 2024
jsnajdr
reviewed
Apr 9, 2024
| type: 'FINISH_RESOLUTIONS', | ||
| selectorName: 'getEntityRecord', | ||
| args: resolutionsArgs, | ||
| } ); |
There was a problem hiding this comment.
If the start and finish actions are batched, then there's no point dispatching START_RESOLUTIONS. The state will be overwritten by FINISH_RESOLUTIONS, and no listener will see the state between start and finish because listeners are not called during a batch.
If some listener is observing the resolution state and expects to see the full cycle, undefined -> resolving -> finished, it might get suprised that it won't ever see resolving. It will go directly to finished. Not sure how much breaking this is.
There was a problem hiding this comment.
I think it probably doesn't really make sense to call "start" in this case, we just want to make these as resolved to avoid requests.
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Mamaduka
reviewed
Jun 5, 2024
| } finally { | ||
| dispatch.__unstableReleaseStoreLock( lock ); | ||
| } ); | ||
| } catch ( e ) { |
There was a problem hiding this comment.
I think we should switch this back to try...finally. The catching error here means it won't be passed to the resolution state (getResolutionError) and might affect the error state for useSuspenseSelect. (#37261).
But that means we won't be able to batch dispatch.__unstableReleaseStoreLock.
gutenberg/packages/data/src/redux-store/index.js
Lines 533 to 535 in 0d1943c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
getEntityRecordscurrently dispatches quite a few actions that are not batched.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast