-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core data: batch actions in all resolvers #60604
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +20 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Flaky tests detected in 346443c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8616490246
|
} | ||
} finally { | ||
} catch ( e ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably same as #60591 (comment).
registry.batch( () => { | ||
dispatch.receiveNavigationFallbackId( fallback?.id ); | ||
|
||
if ( record ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Should we bail out early and reduce nesting?
346443c
to
9bd45cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ellatrix, I think this just needs rebasing to be sure all e2e tests are still passing and should be good to be merged.
What?
A follow-up to #60591. I didn't realise how many resolvers there were that batch multiple actions.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast