List View: Support insert before/after keyboard shortcuts when focus is within the list view #60651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is within the list view
andrewserong
added
[Type] Enhancement
|
Size Change: +63 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Thank you, @andrewserong! The shortcuts are working really well ✅
I tested changes with multiple blocks, including ones that support this feature based on the directInsertBlock setting.
ellatrix
reviewed
Apr 11, 2024
| @@ -189,6 +194,30 @@ function ListViewBlockSelectButton( | |||
| updateFocusAndSelection( updatedBlocks[ 0 ], false ); | |||
| } | |||
| } | |||
| } else if ( isMatch( 'core/block-editor/insert-before', event ) ) { | |||
There was a problem hiding this comment.
Do we share logic here with the normal canvas? Is it worth unifying?
There was a problem hiding this comment.
The logic for the list view needs to be slightly different to the editor canvas, as the list view does a couple of things differently:
- We determine the blocks to update based on the focused item in addition to the block selection (so if the focused list view item is outside of the selection, we ignore the selection and use the focused list view item as the "anchor" block to add blocks either before or after)
- After insertion, we switch focus back to the list view item so that focus remains within the list view
So, I'm not too sure how feasible it'd be to unify this further with how the editor canvas handles things. That said, it could be worth exploring, and to look into how to either neaten things or consolidate things further in a separate PR as this onKeyDownHandler callback is quite long, so if nothing else it might work to move the callback into a hook? In any case, I'll merge this PR in its current form for now, and we can look into code quality follow-ups separately 🙂
|
Thanks for the review! 🙇 |
andrewserong
deleted the
update/support-insert-before-and-after-keyboard-shortcuts-when-list-view-is-focused
branch
11 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #60099
Enable keyboard shortcuts for inserting before or after list view items when focus is within the list view. (The keyboard shortcuts are currently Option+CMD+T to insert before and Option+CMD+Y to insert after).
Why?
These keyboard shortcuts work when focus is within the editor canvas, and it's already supported in the list view via the block settings menu. If you're used to these keyboard shortcuts and have focus within the list view, it feels a little broken if the keyboard shortcuts don't work there. This brings consistency to these keyboard shortcuts.
How?
Testing Instructions
Option+CMD+T)Option+CMD+Y)Screenshots or screencast
2024-04-11.15.47.36.mp4