Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: visual feedback and keyboard behaviour tasks for WordPress 6.6 #60099

Closed
6 of 11 tasks
andrewserong opened this issue Mar 22, 2024 · 7 comments
Closed
6 of 11 tasks
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement. [Type] Iteration Scoped iteration of an effort from a tracking issue or overview issue ideally for a major release.

Comments

@andrewserong
Copy link
Contributor

andrewserong commented Mar 22, 2024

Part of #49563, this issue highlights tasks that can be prioritised for inclusion in WordPress 6.6. It is intentionally not exhaustive. For any additions or nice-to-haves, #49563 is a good tracking issue to use 🙂

The List View referred to in this issue is in the left-hand sidebar (the one that is a list of all the blocks in the current document).

Prioritised List View tasks for WordPress 6.6

Nice-to-haves

Deprioritised

Deprioritised issues are ones the were originally slated for 6.6 but have been punted from the release:

Pull requests

@andrewserong andrewserong added [Type] Enhancement A suggestion for improvement. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Iteration Scoped iteration of an effort from a tracking issue or overview issue ideally for a major release. labels Mar 22, 2024
@Marc-pi
Copy link

Marc-pi commented Mar 25, 2024

@andrewserong seems i've to put this there, since it's related
we also have a not very nice visually experience with the dotted menu in list view, when clicking on child elements that have themsleves child elements (columns, buttons, etc.)

the issue : since we have plenty of space, the horizontal scroll should not occur.

ex1 : within a group, i've a buttons block, i click on the options (either through the ellipsis 3 dots, or by right click)
ex2 : within a group, i've a columns block

context :

  • screensize 15'
  • when editing a page/article
  • i dot not face this in the template editing as long as i tested

image

image

NB : seems ok with the Query Loop

@andrewserong
Copy link
Contributor Author

Thanks for reporting @Marc-pi! Which operating system and browser are you using? On a Mac running Google Chrome with scrollbars set to display, I see a vertical scrollbar on the block settings menu, but no horizontal one. Ideally if a vertical scrollbar is needed, we wouldn't be displaying that horizontal one, so I'm wondering if there's something that's specific to the browser that's causing them to be displayed? If so, I'm wondering if there are any styling adjustments we can make so that only the vertical one is shown 🤔

image

@Marc-pi
Copy link

Marc-pi commented Mar 27, 2024

@andrewserong hello
you are right, i'm on FF / MS Windows
it is ok in Chrome, so the culprit is the way Firefox manages this
thx for the upcoming fix

@andrewserong
Copy link
Contributor Author

Just a tiny update: I can reproduce that issue with the horizontal scrollbars in FF on Windows 11. I've opened a separate issue for that over in #60355 so we can track it separately. I've linked it in the prioritised tasks of this tracking issue.

@andrewserong
Copy link
Contributor Author

Quick update: it turns out I'll have less bandwidth for contributing to this tracking issue for 6.6 than I originally anticipated. As it stands, I believe we'll likely get in all (or most) of the intended keyboard shortcuts improvements for 6.6. Also, the information density / spacing has been tightened for the list view in #60713 which results in a much more usable space for navigating deeply nested lists, with the horizontal scrollbar now seldom appearing. This means that the issue #53096 (make it possible to adjust the width of the list view) is likely no longer necessary.

So, what all this means is that the main "might not make it" feature in 6.6 is the continuing improvement of displacement in the list view by exploring a drag chip that resembles the list view item (#56539). As such, I have moved this to the "nice to have" section in the issue description.

CC: @annezazu for visibility on 6.6 intended features.

@fabiankaegy fabiankaegy moved this from 🏗️ In Progress to Iteration Tracking Issues in WordPress 6.6 Editor Tasks May 21, 2024
@fabiankaegy
Copy link
Member

Hi all 👋

Reminder: The release candidate for Gutenberg Version 18.5 is scheduled for next Friday (May 31st). So anything that is supposed to make it into WordPress 6.6 must be merged by then.

Please raise any important issues that need additional attention :)

@andrewserong
Copy link
Contributor Author

I'll close this issue out now as there were no additional PRs to make it in time for 6.6 Beta 1. I've copied those issues not addressed from this tracking issue over into the long-term issue in #49563 so that they're captured for future releases. The update from May 1 (and list of merged PRs in the issue description) still represent what made it in for 6.6. In brief:

  • Keyboard shortcuts to insert before and after the current item (CMD+Option+T and CMD+Option+Y)
  • Keyboard shortcut to collapse items other than the focused one (Option+L)
  • Keyboard shortcut to group the current selection (CMD+G)
  • Tightened spacing visually, so that users very rarely need to scroll the list view horizontally

@github-project-automation github-project-automation bot moved this from 📋 Iteration/Tracking Issues to ✅ Done in WordPress 6.6 Editor Tasks Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement. [Type] Iteration Scoped iteration of an effort from a tracking issue or overview issue ideally for a major release.
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants