Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Autocompleter: Force icon color to text color when item is selected #61376

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Block Autocompleter: Force icon color to text color when item is selected #61376

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b512e4b
Block Autocompleter: Force icon color to text color when item is sele…
t-hamano May 4, 2024
426c711
Merge branch 'trunk' into block-autocompleters-force-color
t-hamano Aug 7, 2024
c807906
Don't rely on css class
t-hamano Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/block-editor/src/autocompleters/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
.block-editor-block-icon {
margin-right: $grid-unit-10;
}

&[aria-selected="true"] .block-editor-block-icon {
color: inherit !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a way to choose between coloured or block and white icons? Should we always choose black and white for autocomplete maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even !important's can be overridden by plugins if they want it enough — at least until we can shadow-DOM these components :)

I'd tend to agree that color for blocks should be enforced in this view, it's a way to enforce contrast.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a way to choose between coloured or block and white icons? Should we always choose black and white for autocomplete maybe?

If we choose white/black, I think all we need to do is delete showColors here.

image

In my experience, some block plugins color their icons to highlight their branding. Therefore, I think it is better to respect the colored icon when the block is not selected.

}
}

.block-editor-autocompleters__link {
Expand Down
Loading