Block Autocompleter: Force icon color to text color when item is selected #61376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +40 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
P.S. We might want to apply this approach to the list view as well.
|
ellatrix
reviewed
May 6, 2024
| @@ -4,6 +4,10 @@ | |||
| .block-editor-block-icon { | |||
| margin-right: $grid-unit-10; | |||
| } | |||
|
|
|||
| &.is-selected .block-editor-block-icon { | |||
| color: inherit !important; | |||
There was a problem hiding this comment.
Was there a way to choose between coloured or block and white icons? Should we always choose black and white for autocomplete maybe?
There was a problem hiding this comment.
Even !important's can be overridden by plugins if they want it enough — at least until we can shadow-DOM these components :)
I'd tend to agree that color for blocks should be enforced in this view, it's a way to enforce contrast.
There was a problem hiding this comment.
Was there a way to choose between coloured or block and white icons? Should we always choose black and white for autocomplete maybe?
If we choose white/black, I think all we need to do is delete showColors here.
In my experience, some block plugins color their icons to highlight their branding. Therefore, I think it is better to respect the colored icon when the block is not selected.
ellatrix
approved these changes
May 6, 2024
tyxla
approved these changes
Aug 5, 2024
|
Nice one. Thank you! |
|
Flaky tests detected in c807906. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10283260561
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #60131
What?
This PR overrides the icon color in the Block Autocompleter popover when an item is selected, increasing icon visibility.
Why?
#60131 changed the background color of selected items to the primary color. In the block autocompleter, icons are rendered via the
BlockIconcomponent. This component references theforegroundandbackgroundof the icon prop and injects its color as inline styles. As a result, the icons are always the same color, which can reduce visibility.How?
When the button is selected, overrides the color of the block icon component with
inherit. This will inherit the appropriate color and match the button text color.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
4c6ed0b0d02ed9920a3df9267b542383.mp4