Autocompleter UI: Fix text color when hovering selected item #64294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
commented
Aug 6, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -170 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Tests well for me and I can see the darker background color as described 👍
Oddly enough, I wasn't able to reproduce the original issue in trunk. Perhaps I'm missing something.
Scratch that, I reproduced it, and confirmed this PR fixes it 👍
Finally, I think it would be a god idea to keep the selected class as some 3rd party plugins might be relying on it.
|
|
||
| &.is-selected, | ||
| &:not(:disabled,[aria-disabled="true"]):active { | ||
| background: $components-color-accent; |
There was a problem hiding this comment.
I'm personally fine with that change 👍
Do we need a design approval on the darker hover of the selected item?
There was a problem hiding this comment.
@WordPress/gutenberg-design
I think it's fine for now, as it's consistent with the primary Button variant. However, I'm wondering if these styles should eventually be refactored/consolidated with DropdownMenu(v2). I think we can say they are the same UI pattern, but the selected item is styled differently:
There was a problem hiding this comment.
Hover color looks fine and is consistent with primary buttons. I'd agree the more we can consolidate, simplify, the better.
tyxla
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #62480
What?
This PR fixes the text color when a selected item is hovered in Autocompleter UI.
Why?
In #62480, some CSS selector changes were made to improve button focus styles.
As a result, when an item is selected within the Autocompleter UI, i.e. when the background color is the primary color, the text color also changes to the primary color, making the text and icon invisible.
How?
I think the fundamental problem is that Autocompleter UI uses a unique selector called
is-selectedto indicate that an item is selected, which may conflict with the style of the Button component.We should be able to achieve a similar look without using this selector by setting the
variantprop toprimary. As a secondary benefit, it also allows for hover styling that is not currently applied (the background color becomes slightly darker).Testing Instructions
Additionally, to test our own autocomplete, install the following plugin and enter the character
~:fruit-autocompleter.zip
Screenshots or screencast
Before
before.mp4
After
after.mp4