Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disabled checkbox cursor style #62411

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

amitraj2203
Copy link
Contributor

What?

Fixes: #62349

Why?

In the Site Editor's data views, checkboxes remain visible even when items are unselectable, causing confusion and suggesting interaction.

How?

Changing the cursor to not allowed for unselectable items in the Site Editor improves clarity and usability.

Testing Instructions

  1. Open site editor.
  2. Select Templates.
  3. Try to select the unselectable templates.

Screenshots or screencast

Screen.Recording.2024-06-07.at.4.29.18.PM.mov

Copy link

github-actions bot commented Jun 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: amitraj2203 <amitraj2203@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@amitraj2203 amitraj2203 added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Jun 7, 2024
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good code-wise, but I'm going to cc: @WordPress/gutenberg-design so designers can have a look.

@jorgefilipecosta jorgefilipecosta added the Needs Design Feedback Needs general design feedback. label Jun 19, 2024
@jameskoster
Copy link
Contributor

I think this is reasonable. Visually there may not be enough contrast between enabled/disabled checkboxes, and the cursor helps mouse users. The question I have is whether the cursor should be applied holistically across all disabled elements.

@jameskoster jameskoster added the Needs Accessibility Feedback Need input from accessibility label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Accessibility Feedback Need input from accessibility Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data views: hide checkboxes in grid layout when unable to select
3 participants