Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views: hide checkboxes in grid layout when unable to select #62349

Closed
annezazu opened this issue Jun 5, 2024 · 4 comments · May be fixed by #62411
Closed

Data views: hide checkboxes in grid layout when unable to select #62349

annezazu opened this issue Jun 5, 2024 · 4 comments · May be fixed by #62411
Assignees
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Jun 5, 2024

When viewing items in data views in the Site Editor, checkboxes are shown even if you can't actually select anything. Every time I see this, I still think I can check the box so either the greyed out look needs to shift, the checkboxes need to be removed if you can't select an item, or something else I can't think of right now :) Connecting the dots, it looks like there's feedback to have checkboxes always be visible in certain layouts #59175

Here's a video showing what I mean:

checkboxes.mov
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Jun 5, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 7, 2024
@amitraj2203
Copy link
Contributor

Every time I see this, I still think I can check the box so either the greyed out look needs to shift, the checkboxes need to be removed if you can't select an item, or something else I can't think of right now

Hi @annezazu, I have raised a PR for this which adds cursor: not-allowed; to the unselectable items.

@annezazu
Copy link
Contributor Author

@jameskoster while we've iterated on this and de-emphasized the checkbox option (only shown when hovering), I find it odd that a greyed out checkbox shows at all when using 6.6.1 and GB 19.0:

hover.grey.out.mov

From what I can see in prior PRs we turned off the checkbox when there aren't any actions to take #58950 Curious what the intent is here.

@jameskoster
Copy link
Contributor

In table layout the checkboxes are removed entirely when there are no applicable bulk actions. I agree it makes sense to do the same thing in Grid layout as well. What do you think @jorgefilipecosta?

@ntsekouras
Copy link
Contributor

This was resolved here by removing the checkbox if no bulk actions exist for any item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants