Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Hide actions related UI in grid when no actions or bulk actions are passed #68033

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ntsekouras
Copy link
Contributor

What?

Discovered while exploring #68030.

This PR fixes two small things in DataViews grid layout:

  1. Do not render the multi selection checkbox on items, when no bulk actions exist
  2. Do not render the disabled actions dropdown trigger if no actions are passed.

We have similar handling in table layout.

Testing Instructions

  1. Everything should work as before in existing usages of DataViews
  2. You could test in trunk by removing the actions in templates here

@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Dec 16, 2024
@ntsekouras ntsekouras self-assigned this Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ntsekouras ntsekouras enabled auto-merge (squash) December 16, 2024 16:08
@ntsekouras ntsekouras merged commit 2eb82b4 into trunk Dec 16, 2024
72 checks passed
@ntsekouras ntsekouras deleted the fix/handle-better-no-actions-in-grid-dataviews branch December 16, 2024 16:14
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 16, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…actions are passed (WordPress#68033)

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…actions are passed (WordPress#68033)

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants