CustomSelectControlV2: Fix styling issues
#62424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullofcaffeine
changed the base branch from
trunk
to
fix/custom-select-control-v2-legacy-adapter-set-and-select-initial-value
|
Size Change: +4.67 kB (+0.27%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
fullofcaffeine
commented
Jun 7, 2024
fullofcaffeine
commented
Jun 7, 2024
…d keep it at a predictable height regardless of the number of children
fullofcaffeine
commented
Jun 7, 2024
fullofcaffeine
commented
Jun 7, 2024
fullofcaffeine
commented
Jun 7, 2024
fullofcaffeine
commented
Jun 7, 2024
fullofcaffeine
commented
Jun 7, 2024
| position: absolute !important; | ||
| max-height: 400px; | ||
| overflow: auto; | ||
| min-width: 100%; |
There was a problem hiding this comment.
I can't replicate the popover width issue on Storybook — plus, it seems like we're already passing the sameWidth prop to the underlying Ariakit implementation
fullofcaffeine
commented
Jun 7, 2024
85 tasks
|
I'm going to take over the work on this PR. I will review this PR and see:
I will then take over authoring, either in this PR or in a new one. |
This was referenced Jun 24, 2024
|
We can close this issue, since all fixes proposed have been iterated on / moved to separate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from: #61272.
Depends on: #62308.
What?
Fix styling issues found while testing it via the legacy adapter. See each commit for a description of each fix.
Why?
We're preparing V2 for shipping, and these visual issues need to be fixed before we replace the V1 implementation with the adapter. This is part of a series of PRs with other fixes/tweaks to the new control (see the top of the description).
How?
By tweaking the CSS rules for the various elements that make up the component.
Testing Instructions
Check all the stories in storybook - for V2 and the adapter. Make sure they look alright;
Then tests with consumers. Here are a few consumers that can be used to test it in practice:
wp-admin/site-editor.php?canvas=edit: Add adateblock and uncheck the "Default format' checkbox in the settings in order for the select to show;spacerblock, and in the "Height" settings, there's a custom select for it as well.There's another one under https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/hooks/position.js#L290, but I couldn't find exactly where this feature is yet.
Other slight visual changes might also be made, and the review's goal is to discuss whether it's okay to keep them or if we should fix them (as in making it exactly/closer to V1).
TODO
Screenshots or screencast