Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomSelectControlV2: Fix styling issues #62424

Closed
wants to merge 8 commits into from
Closed

CustomSelectControlV2: Fix styling issues #62424

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b3848b4
Fix select popover not appearing on top of all elements on the page
fullofcaffeine Jun 7, 2024
ba60bcf
Fix select popover opening direction
fullofcaffeine Jun 7, 2024
a1b9b3e
Set a `max-height` for the popover to follow the UI behavior of V1 an…
fullofcaffeine Jun 7, 2024
ef1b6b6
Add `overlflow: auto` so that scrolling through items is possible
fullofcaffeine Jun 7, 2024
8142ef7
Fix select label bottom margin
fullofcaffeine Jun 7, 2024
787089a
Fix selection cursor when hovering over items in the popover
fullofcaffeine Jun 7, 2024
7e7dfe5
Make popover always match the width of the select
fullofcaffeine Jun 7, 2024
df788ca
Make long hint content wrap if too long
fullofcaffeine Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/components/src/custom-select-control-v2/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ export const SelectPopover = styled( Ariakit.SelectPopover )`
border-radius: 2px;
background: ${ COLORS.theme.background };
border: 1px solid ${ COLORS.theme.foreground };
z-index: 9999; // Ensure the popover is on top
ciampo marked this conversation as resolved.
Show resolved Hide resolved
position: absolute !important;
ciampo marked this conversation as resolved.
Show resolved Hide resolved
max-height: 400px;
ciampo marked this conversation as resolved.
Show resolved Hide resolved
overflow: auto;
ciampo marked this conversation as resolved.
Show resolved Hide resolved

&[data-focus-visible] {
outline: none; // outline will be on the trigger, rather than the popover
Expand Down
Loading