Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert test data for WithSlug variation #62579

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Revert test data for WithSlug variation #62579

merged 1 commit into from
Jun 14, 2024

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Jun 14, 2024 •
edited
Loading

What

Removes test data, so it doesn't trigger this error in CI tests.

See slack conversation in the core-editor channel.

Why

To unblock further PRs from landing. We'll continue investigating this and will add it back.

How

Undoes the changes to the test and removes the corresponding data. We don't know the source of the issue yet.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal oandregal self-assigned this Jun 14, 2024
@oandregal oandregal added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Jun 14, 2024
@github-actions GitHub Actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core GitHub repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ phpunit/block-supports/block-style-variations-test.php
❔ phpunit/class-wp-theme-json-resolver-test.php

@oandregal oandregal added the [Type] Bug An existing feature does not function as intended label Jun 14, 2024
@oandregal oandregal changed the title Revert test data until we can investigate it deeper Revert test data for WithSlug variation Jun 14, 2024
aaronrobertshaw
aaronrobertshaw approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

✅ Reverted tests and partial match #62550
✅ Tests pass locally again after checking out this PR

Thanks for putting this PR up to unblock others 🙇

@oandregal oandregal merged commit 2917269 into trunk Jun 14, 2024
68 of 70 checks passed
@oandregal oandregal deleted the revert/test-data branch June 14, 2024 12:45
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 14, 2024
oandregal added a commit that referenced this pull request Jun 14, 2024
@oandregal
Revert "Revert test data for WithSlug variation (#62579)"
23b2851 
This reverts commit 2917269.
@oandregal oandregal mentioned this pull request Jun 14, 2024
Merged
@aaronrobertshaw aaronrobertshaw mentioned this pull request Jun 15, 2024
Merged
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
@oandregal @patil-vipul
Revert test data for WithSlug variation (WordPress#62579)
5bf007d
oandregal added a commit that referenced this pull request Jun 17, 2024
@oandregal
Revert "Revert test data for WithSlug variation (#62579)"
3d05810 
This reverts commit 2917269.
ramonjd added a commit that referenced this pull request Jun 18, 2024
@oandregal @andrewserong
@aaronrobertshaw @tellthemachines @ramonjd
Revert "Revert test data for WithSlug variation (#62579)" (#62587)
2fdcec7 
* Revert "Revert test data for `WithSlug` variation (#62579)"

This reverts commit 2917269.

* Clear up test caching

Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronrobertshaw aaronrobertshaw aaronrobertshaw approved these changes

Assignees

@oandregal oandregal

Labels
No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 18.6
Development

Successfully merging this pull request may close these issues.
2 participants
@oandregal @aaronrobertshaw