Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the reference links in @wordpress/compose documentation. #62593

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

vipul0425
Copy link
Contributor

What?

Updates the reference link in the @wordpress/compose documentation.

Why?

The old reference link for hooks goes to the https://legacy.reactjs.org/docs/hooks-intro.html, so updated this to the new documentation link and for Higher Order Components goes to https://facebook.github.io/react/docs/higher-order-components.html which is giving not found error. So updated this with the legacy link as new documentation doesn't have specific page for it.

@vipul0425 vipul0425 requested a review from ajitbohra as a code owner June 14, 2024 18:55
Copy link

github-actions bot commented Jun 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vipul0425 <vipulgupta003@git.wordpress.org>
Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>
Co-authored-by: shail-mehta <shailu25@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta added the [Type] Developer Documentation Documentation for developers label Jun 15, 2024
@shail-mehta
Copy link
Member

@vipul0425

There is another instance of the URL https://reactjs.org/docs/hooks-intro.html in docs/contributors/code/coding-guidelines.md at line 761. Could you please update the URL in that file as well?

@juanmaguitar
Copy link
Contributor

LGTM! ✅

@akasunil akasunil merged commit e056b9d into WordPress:trunk Jun 19, 2024
64 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.7 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants