-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: simplify test set up in WP_Block_Supports_Block_Style_Variations_Test
#62637
Tests: simplify test set up in WP_Block_Supports_Block_Style_Variations_Test
#62637
Conversation
…ean_cached_data(), after test suite runs, not just after any tests
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for cleaning that up, appreciate it!
Thanks for the quick test @aaronrobertshaw If the tests fail for whatever reason I'll revert this. Hopefully the ghosts have been chased away. |
When I first re-rant the tests locally, I hit the error #62587 addressed. I had to run |
What?
A PR to simplify test set up in
WP_Block_Supports_Block_Style_Variations_Test
How?
Clean all JSON caches, including WP_Theme_JSON_Resolver_Gutenberg::clean_cached_data(), after test suite runs, not just after any testsLetting
_gutenberg_clean_theme_json_caches()
do the work. It runs intear_down()
.Testing Instructions
CI should pass.
npm run test:unit:php
should pass locally.