Fix: Error while Calling edit-site getCurrentTemplateTemplateParts selector #63818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +238 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Thanks for the fix, @jorgefilipecosta
A couple of high-level notes:
- It's now possible to memoize registry selectors (see Data: fix memoized createRegistrySelector #57888), which means we can drop the
getFilteredTemplatePartBlockshelper. - Let's restore logic for
getFilteredTemplatePartBlocksinedit-sitepackages instead of re-adding a private selector. Colocation hopefully will prevent similar bugs in the future.
Edit: Sorry, miss-clicked the approval. Let's merge after these changes.
…ts() selector throws an error.
jorgefilipecosta
force-pushed
the
fix/core/edit-site-getCurrentTemplateTemplateParts-throws-an-error
branch
from
4cc89f8
to
1f64df8
Compare
jorgefilipecosta
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
Mamaduka
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Thanks for the follow-ups, @jorgefilipecosta!
I think this is good to be merged ✅
jorgefilipecosta
deleted the
fix/core/edit-site-getCurrentTemplateTemplateParts-throws-an-error
branch
|
Thank you for the reviews @Mamaduka! |
westonruter
added a commit
that referenced
this pull request
Jul 23, 2024
* trunk: (2604 commits) Update "Versions in WordPress" page (#63869) SelectControl: Fix hover/focus color in wp-admin (#63855) Add margin-bottom lint rules for RangeControl (#63821) JSON Schema Docgen Rework (#63868) JSON Schema Reorganization and Fixes (#63591) DataForm: Add a simple story for the DataForm component (#63840) Quick Edit: Support bulk selection (#63841) Update dataviews docs (#63860) Bump the github-actions group across 1 directory with 4 updates (#63808) Add unit tests for the gutenberg_render_block_core_post_title() function. Make hover block outlines not present in Distraction Free (#63819) DataViews: Rename the header property of fields to label (#63843) Fix: Error while Calling edit-site getCurrentTemplateTemplateParts selector (#63818) Revert "Update HeightControl component to label inputs" (#63839) Zoom out: hide vertical toolbar when block is not full width (#63650) Latest comments: Add color block support (#63419) Core Data: Remove leftover 'todo' comment (#63842) Tabs: keep full opacity of focus ring on disabled tabs (#63754) Fix selected row styles in table layout (#63811) Align checkbox, radio, and toggle input design (#63490) ...
priethor
added
the
[Feature] Site Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue correctly pointed out by @Mamaduka at https://github.com/WordPress/gutenberg/pull/62033/files#r1673431541.
We removed the editor private selector getCurrentTemplateTemplateParts but "edit-site" had an equivalent public selector that just called the editor private selector. Removing made the public selector throw an error. Checking the plugin repository this selector has some usage so we can not remove it right now.
Testing Instructions
On the browser console, I pasted
await wp.data.select('core/edit-site').getCurrentTemplateTemplateParts();.I verified the selector worked as expected and there was a deprecation warning on the console.