Add margin-bottom lint rules for RangeControl #63821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 tasks
|
Size Change: +469 B (+0.03%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
mirka
commented
Jul 22, 2024
There was a problem hiding this comment.
Testing instructions
Add a Post Excerpt block, and see the block inspector. No visual changes.
There was a problem hiding this comment.
Testing instructions
Add a Grid block and see the Layout section in the block inspector. Toggle the Grid Item Position to switch between the two RangeControls. No visual changes.
| Auto | Manual |
|---|---|
 |
 |
There was a problem hiding this comment.
Testing instructions
Add a Query block and click the pagination numbers to select the Page Numbers block. See the block inspector.
| Before | After |
|---|---|
 |
 |
Excessive margin at the bottom of the help text is slightly reduced.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
LGTM 🚀
Should we also apply changes to RangeControl to:
- add the
__nextHasNoMarginBottomprop to all example usages in JSDocs - change the default
__nextHasNoMarginBottomvalue in Storybook totrue - Update any relevant docs in types and README
to match other components that are also linted for the usage of the __nextHasNoMarginBottom prop?
tyxla
approved these changes
Jul 23, 2024
Right, I forgot, thanks! (Note that I haven't been changing the Storybook defaults yet since it's still not the component default though.) |
westonruter
added a commit
that referenced
this pull request
Jul 23, 2024
* trunk: (2604 commits) Update "Versions in WordPress" page (#63869) SelectControl: Fix hover/focus color in wp-admin (#63855) Add margin-bottom lint rules for RangeControl (#63821) JSON Schema Docgen Rework (#63868) JSON Schema Reorganization and Fixes (#63591) DataForm: Add a simple story for the DataForm component (#63840) Quick Edit: Support bulk selection (#63841) Update dataviews docs (#63860) Bump the github-actions group across 1 directory with 4 updates (#63808) Add unit tests for the gutenberg_render_block_core_post_title() function. Make hover block outlines not present in Distraction Free (#63819) DataViews: Rename the header property of fields to label (#63843) Fix: Error while Calling edit-site getCurrentTemplateTemplateParts selector (#63818) Revert "Update HeightControl component to label inputs" (#63839) Zoom out: hide vertical toolbar when block is not full width (#63650) Latest comments: Add color block support (#63419) Core Data: Remove leftover 'todo' comment (#63842) Tabs: keep full opacity of focus ring on disabled tabs (#63754) Fix selected row styles in table layout (#63811) Align checkbox, radio, and toggle input design (#63490) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38730
What?
Adds eslint rules to prevent new instances of
RangeControlto be introduced in the Gutenberg codebase without the__nextHasNoMarginBottomprop being added.Why?
These lint rules should prevent new violating usages from being added, until we are ready to officially deprecate the margins on the BaseControl-based components all at once.
Testing Instructions
See code comments.