Comment Edit Link: Add Border Block Support #64239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shail-mehta
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +179 B (+0.01%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a5bea46. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10237479983
|
There was a problem hiding this comment.
Thank you for all the effort towards greater adoption of border block supports @shail-mehta 👍
As noted over on #64271, it might pay to hold off on landing this change until it is confirmed whether the spacing and border controls should be displayed by default for blocks such as this one.
shail-mehta
force-pushed
the
add/comment-edit-link-border-support
branch
from
4e56762 to
6f3b424
Compare
shail-mehta
force-pushed
the
add/comment-edit-link-border-support
branch
from
6f3b424 to
a3f421a
Compare
|
Based on the Feedback #64271 (comment) I have added spacing and border controls optional in this PR & Comment Reply Link's PR |
ramonjd
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Thanks for the update.
✅ Comment Edit Link block's border is Configurable via Global Styles.
✅ Comment Edit Link block styles take precedence over global Styles.
✅ Comment Edit Link block borders display correctly in both the Editor and Frontend.
Also, at the block level, margin and padding controls are hidden by default.
|
Thank you for the review. |
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Comment Edit Linkblock.Part of #43247
Why?
Comment Edit Linkblock is missing border support.How?
Adds the border block support in block.json.
Testing Instructions
Comment Edit Linkblock's border is Configurable via Global Styles.Comment Edit Linkblock and Apply the border Styles.Comment Edit Linkblock styles take precedence over global Styles.Comment Edit Linkblock borders display correctly in both the Editor and Frontend.Screenshots or Screencast
add-border-support-in-comment-edit-link.mp4